Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix war file path as argument for jetty runner #527

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

JesseChavez
Copy link
Contributor

@JesseChavez JesseChavez commented Sep 23, 2022

This fix the war file path that is given to the embedded Jetty runner.

Before this change:
(only works in older jetty version older than 9.4.32.v20200930)

invoking webserver with:
[--host, 0.0.0.0, --port, 8080, --config, jar:file:/D:/workbench/samson.war!/WEB-INF/webserver.xml, /D:/workbench/samson.war]

After this change:
(works for newer jetty versions starting with 9.4.32.v20200930, includes jetty 10.x)

invoking webserver with:
[--host, 0.0.0.0, --port, 8080, --config, jar:file:/D:/workbench/samson.war!/WEB-INF/webserver.xml, D:\workbench\samson.war]

@JesseChavez
Copy link
Contributor Author

No sure if I have to commit the generated jar file lib/warbler_jar.jar

ext/JarMain.java Outdated Show resolved Hide resolved
Copy link
Member

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the .jar commit should not be necessary (unfortunately it kind of is atm).

The .jar changes so rarely that it's not part of rake release to rake build the .jar.
But I think it's also a feature as it allows using Warbler from github: 'jruby/warbler' git.

For security reasons and to make sure compilation happens with the tools (Java version) intended it's best if it's performed by a maintainer (as a follow up of merging the PR).

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JesseChavez!

Thanks @kares for a clear review!

I will make a sign-post Issue about "regenerate the JAR".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

war file with Jetty fails to boot up in Windows (broken due changes in Jetty version 9.4.32.v20200930 onward)
3 participants