Migrate CI to Github Actions #497
Conversation
|
Github Actions needs to be enabled in this repo so that CI runs, but you can see a passing CI on my fork: https://github.com/deivid-rodriguez/warbler/actions/runs/922559866. |
deivid-rodriguez
force-pushed
the
github_actions
branch
from
9e80438
to
79b5dbd
Compare
|
@deivid-rodriguez Alright, ready! |
deivid-rodriguez
force-pushed
the
github_actions
branch
from
79b5dbd
to
deb53c8
Compare
|
Rebased! You'll need to enabled Github Actions in the repo settings. |
deivid-rodriguez
force-pushed
the
github_actions
branch
from
ae2be3f
to
f399841
Compare
|
I believe that you don't need to enable anything and GitHub Actions will start working for this repo as soon as workflow files are merged. |
|
You need to go to "Settings > Actions", and then select an appropriate radio button under "Actions Permissions" such as "Allow all actions". Not sure whether it gets automatically enabled if workflow files land on master, but manually enabling it is better to get CI feedback beforehand and be able to merge a working setup. |
|
Even if you enable that (in case it is disabled which I doubt), I think GitHub Actions won't run for this PR. Because current repository doesn't contain a workflow file that would allow running builds against PRs. |
|
Yeah, it would because I'm temporarily specifying the current branch name in the workflows. |
|
I've already done this many times. |
|
In any case, I'm testing this against my fork, so no need to enable anything, I can ping you when it's ready, and we can merge directly and get it running on master 👍. |
|
@olleolleolle @deivid-rodriguez I see an actions tab and it is suggesting I either pick a work flow or commit the normal GHA files to the repo. So I think it is enabled but not displaying because we have not committed the files yet? |
|
Yeah, that's normal. As @slonopotamus said, once we land this PR workflows should start running. Can you check the permissions enabled at "Settings > Actions"? Maybe my trick only works for branches inside the repository, not from branches in forks. |
|
@deivid-rodriguez It is set to 'allow all actions' which appears to be any location and any author. |
|
Yeah, thanks! So indeed my trick only works for branches inside the repository (which makes sense). That's why actions are running fine on my fork without having any workflow files on master: https://github.com/deivid-rodriguez/warbler/actions. This is good enough, I'll ping you when I have something ready. |
It makes it easier to configure a Github Actions matrix.
deivid-rodriguez
force-pushed
the
github_actions
branch
2 times, most recently
from
a4ef543
to
0956bc1
Compare
On Github Actions, jruby-head installation is more standard, so it comes with a very new bundler installed as a default gem. This means that unless we use a rubygems version that can switch the version of bundler according to what's locked in Gemfile.lock, things won't work because the default version of bundler (bundler 2) will be used and that doesn't work yet. So, in preparation for migrating to Github Actions, I'm updating rubygems to the minimal version that includes this feature and hope that it works fine otherwise.
deivid-rodriguez
force-pushed
the
github_actions
branch
from
0956bc1
to
2e2887c
Compare
|
Alright, this should be ready now. Passing CI in my fork is here: https://github.com/deivid-rodriguez/warbler/actions/runs/926438002. |
I was working on #494 but I noticed travis-ci.org shutdown was imminent so I figured I would migrate the CI to Github Actions.
I didn't migrate the jruby 9.0 entries, because they're being removed at #491, so I'll wait for that and then rebase this PR.