Remove using namespace from all public headers #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix all instances of C4819 and other encoding related issues
Fix compilation of downstream projects
gergondet
added a commit
that referenced
this pull request
May 28, 2021
- Fix charset issues with MSVC - Avoid namespace pollution (#37) - Add the computation for the inverse of the right jacobian for SO(3) and its derivative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public headers used
using namespace Eigenwhich brings in all Eigen names into thesvanamespace. This PR changes this and make the required changes elsewhere.All header files can now be included individually as well.
Note: I've kept
vector(3|6)ToCross(Dual)Matrixin thesvanamespace in case they are used in some downstream projects.