Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_origin_slice - Check for 2 peaks when looking for key CBCT slice #482

Closed
wants to merge 1 commit into from

Conversation

t-milan
Copy link

@t-milan t-milan commented Feb 21, 2024

We noticed the CBCT module for our CatPhan604 was failing to find the proper keyslice of the CBCT - the find_origin_slice method looks for the middle slice within a range, but that range is too large.
As you can see in the image below, there are extra slices which don't contain all the HU modules, which we want to ignore. My solution is to add an extra check that the proper slices should have 2 peaks in the Circular Profile. Once we added this, the proper key slice was found.
Hope that makes sense. Unfortunately I haven't been able to test this for other CatPhan models.
CBCT_Peak_Examples

@jrkerns
Copy link
Owner

jrkerns commented Feb 21, 2024

There's a PR and discussion about this here: #426.

What version are you using? In v3.19 the 604 origin slice algorithm was adjusted: https://pylinac.readthedocs.io/en/latest/changelog.html#ct

@t-milan
Copy link
Author

t-milan commented Feb 22, 2024

Thanks for that - You're right, I tested the latest version but didn't see the fix because I was using my own custom CatPhan604 class overriding CatPhanBase, which therefore didn't have the refine_origin_slice method.
The fix from #426 seems to work fine for me so you can ignore my solution.

@t-milan t-milan closed this Feb 22, 2024
@t-milan t-milan deleted the fix-cbct-keyslice branch February 22, 2024 01:51
@jrkerns
Copy link
Owner

jrkerns commented Feb 22, 2024

Your solution is a lot more clever than mine! Good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants