leaf_under_y_jaw modified
#147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New upstream updates
The original function seems not calculating the HDMLC case correctly, here is a rewrote.
|
Hi Hideki, It looks like there's some syntax issues that need to be addressed first before we get too far: https://travis-ci.org/jrkerns/pylinac/jobs/447615836#L970 |
build status reflect forked build status
correcting logic errors
|
Hi James, Sorry about that, I'll correct the syntax errors first. |
more logic errors...
last error (hopefully)
jrkerns
added a commit
that referenced
this pull request
Dec 30, 2022
RAM-2235 add Elekta MLC options * add Elekta options Approved-by: Randy Taylor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi James,
the
:MLC: Leaf_under_y_jawfunction seems not judging whether the leaf is under the jaw for HDMLC case correctly. Here is a PR for that.Sorry that there are three commits in this PR and I am pretty new on GitHub/Git related issues. If the multiple commits need to be merged into one I'll do that then (If you could provide some clue on how to do that, that would be great too).
Thank you for looking into this matter.