Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Use the new watchApi introduced in [email protected] #76

Merged
merged 5 commits into from
Mar 8, 2018
Merged

Use the new watchApi introduced in [email protected] #76

merged 5 commits into from
Mar 8, 2018

Conversation

sheetalkamat
Copy link
Contributor

This is upgrade from #74 to ensure backward compatibility with previous typescript versions

@jrieken
Copy link
Owner

jrieken commented Mar 5, 2018

Hm... I have noticed that getting this version of gulp-tsb up and running is significantly slower than tsc in watch mode (160sec vs 50sec). Any idea why?

@jrieken jrieken self-assigned this Mar 5, 2018
@jrieken
Copy link
Owner

jrieken commented Mar 5, 2018

My bigger plan is that I want those changes and I wanna throw out the old. That logic we can keep in the 2.x branch, go to version 3.x on master and support the new world only. My plan would be to merge this PR and do further work on master but first I wanna understand if there is fundamental difference that explains why the startup-perf is so different...

@sheetalkamat
Copy link
Contributor Author

Hm... I have noticed that getting this version of gulp-tsb up and running is significantly slower than tsc in watch mode (160sec vs 50sec). Any idea why?

Which source did you run this on, I can try this on that same source and see whats going on.

@jrieken
Copy link
Owner

jrieken commented Mar 6, 2018

I have used the watch-client target after sym-linking the new version of gulp-tsb. Because of memory flags use npm run gulp watch-client

@jrieken
Copy link
Owner

jrieken commented Mar 8, 2018

Sorry false alarm... Wasn't able to reproduce anymore. I'll proceed with merging this PR

@jrieken jrieken merged commit 095db3d into jrieken:master Mar 8, 2018
@sheetalkamat sheetalkamat deleted the builderApiFinal branch March 8, 2018 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants