Fix for TS 2.4 Module Resolution Changes

[mjbvz]

Fixes #62

Bug
TS 2.4 changes the builder logic, which blocks building vscode using gulp-tsb: microsoft/TypeScript#16772

Fix
Add missing methods as suggested by: https://github.com/TypeStrong/ts-loader/pull/566/files

[jrieken]

We have the noFilesystemLookup-option because we have seen TypeScript spending a lot of time checking the disk for non-existent files. That's why there is this flag and that's why we didn't implement more FS-operations. With gulp-tsb the idea is that all sources needed to build are streamed into the builder and that builder doesn't hunt on disk for more files.

@mjbvz Do you know what has changed in TypeScript such that it doesn't find node.d.ts files anymore? Is this just a matter of setting up the src-streams in a different way? Also did you try running the builder with toggling this flag?

[mjbvz]

@rbuckton @andy-ms Do you know what changed in TS 2.4.1 that broke some build tools? I looked through microsoft/TypeScript#16772 but couldn't determine the root cause. The workaround suggested for ts-loader also worked for us.

Also, please let me know if there is a better workaround for this issue. Here's the branch to build vscode with TS 2.4.1: https://github.com/Microsoft/vscode/tree/build-with-ts24 I tried the noFilesystemLookup option to no effect

[jrieken]

Ok, more is understood. The main portion of our code is compiled with the noFileSystemLookup flag (for performance and for strictness reasons) but for extensions it seems we never cared... Interestingly, for them we only stream src/**.ts-files into the compiler and let it discover the rest by itself. @joaomoreno might know why that is, I see your name on it. We might also have messed it up when adopting @types...

Long story short, already today you cannot compile extensions without enabling extra file lookups and in that spirit we might continue. @mjbvz Please update your pull request to check if extra fs lookups are allowed, with that we are consistent.

[mjbvz]

Thanks. I've added checks for _noFilesystemLookup to the new methods

[jrieken]

thanks