empty commit #27
Draft
empty commit #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhee17
force-pushed
the
gradle/build-cache-jrhee17-pr
branch
from
55bd6a4 to
c20abe3
Compare
jrhee17
force-pushed
the
gradle/build-cache-jrhee17-pr
branch
from
c20abe3 to
10e1c27
Compare
jrhee17
force-pushed
the
gradle/build-cache-jrhee17-pr
branch
from
10e1c27 to
42c0213
Compare
jrhee17
added a commit
to line/armeria
that referenced
this pull request
Aug 25, 2023
Motivation: This PR attempts to solve two problems: - Our CI runs don't necessarily reflect a typical developer's workflow because it is run with specific flags (i.e. `flakyTests`, `noLint`, etc..). For this reason, the populated build caches does not necessarily coincide with that of a developer workflow. - Our CI does not upload build-cache to our remote node yet. In this PR, I propose that we launch a separate build task to populate the build cache for each PR. Additionally, I propose that we retry tests in this task so that flaky tests don't affect build cache upload. Note that I would like to do some more experiments before actually enabling caching for everyone. (It can be done manually by setting the `--build-cache` flag on the CLI) For this reason, in this PR I don't enable the `org.gradle.caching=true` option yet. This will be done after experiments are complete. See the following links for a preview: - jrhee17#27 - https://github.com/jrhee17/armeria/actions/runs/5960198011/job/16167108190 Modifications: - Set up credentials for cache upload. These credentials can be registered at: - https://ge.armeria.dev/cache-admin/node/built-in - Cache access control - Set up remote build cache upload configurations. Note that credentials are only required for writing, as reading can be done anonymously. The cache will be pushed only at the CI if the proper write credentials are supplied (i.e. writing to the `main` branch) - Note that the `gradle-enterprise-postjob.yml` task must be merged to the `main` branch to take effect. - Introduced a `failOnPassedAfterRetry` to prevent build cache uploads tasks from failing due to flaky tests. - Renamed the github task to `gradle-enterprise-postjob.yml` to better reflect the new role. Result: - Build cache is uploaded from CI for each PR/push to `main` branch <!-- Visit this URL to learn more about how to write a pull request description: https://armeria.dev/community/developer-guide#how-to-write-pull-request-description -->
jrhee17
force-pushed
the
main
branch
7 times, most recently
from
191fc43 to
77b0d4b
Compare
jrhee17
force-pushed
the
main
branch
3 times, most recently
from
9abe369 to
d78b39b
Compare
jrhee17
force-pushed
the
main
branch
3 times, most recently
from
4cccd34 to
d9b6142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain why you're making this change and what problem you're trying to solve.
Modifications:
Result: