Skip to content

Commit

Permalink
address comment by @ikhoon
Browse files Browse the repository at this point in the history
  • Loading branch information
jrhee17 committed Nov 20, 2024
1 parent e564f95 commit 06b47bf
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,16 @@ void session(@Nullable Channel channel, SessionProtocol sessionProtocol, @Nullab
* <li>A path pattern and HTTP method name for {@link HttpService}</li>
* </ul>
* This property is often used as a meter tag or distributed trace's span name.
* Note that calling {@link #responseContent(Object, Object)} will automatically fill
* {@link RequestLogProperty#NAME}, so {@link #name(String, String)} must be called beforehand.
*/
void name(String serviceName, String name);

/**
* Sets the human-readable name of the {@link Request}, such as RPC method name, annotated service method
* name or HTTP method name. This property is often used as a meter tag or distributed trace's span name.
* Note that calling {@link #responseContent(Object, Object)} will automatically fill
* {@link RequestLogProperty#NAME}, so {@link #name(String)} must be called beforehand.
*/
void name(String name);

Expand Down

0 comments on commit 06b47bf

Please sign in to comment.