Print "'name' is already defined" message #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates `new_basic_definition` and `define` to print "'name' is already defined" error message if the constant already exists. This also makes `new_definition` print the message because it internally calls `new_basic_definition`. ``` \# new_basic_definition `x=10`;; val it : thm = |- x = 10 \# new_basic_definition `x=20`;; Exception: Failure "new_basic_definition: 'x' is already defined". \# new_definition `x=20`;; Exception: Failure "new_basic_definition: 'x' is already defined". \# define `x=30`;; Exception: Failure "define: 'x' is already defined". ``` Three more definition functions (`new_recursive_definition`, `new_inductive_definition` and `new_specification`) are not updated in this patch. I avoided touching them because their implementations look complicated to me. :/
|
Thanks, a useful improvement in error messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small patch that updates
new_basic_definitionanddefineto print "'name' is already defined" error message if the constant already exists. This also makesnew_definitionprint the message because it internally callsnew_basic_definition.Three more definition functions (
new_recursive_definition,new_inductive_definitionandnew_specification) are not updated in this patch. I avoided touching them because their implementations look complicated to me. :/