Skip to content

Commit

Permalink
GH Actions: set error reporting to E_ALL
Browse files Browse the repository at this point in the history
Turns out the default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`.

For the purposes of CI, I'd recommend running with `E_ALL` and `display_errors=On` to ensure **all** PHP notices are shown.

Ref:
* shivammathur/setup-php#469
* shivammathur/setup-php#450
  • Loading branch information
jrfnl committed Jun 22, 2021
1 parent c90ed07 commit b8b5940
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:

env:
PHP_EXTENSIONS: dom, json, libxml, mbstring, pdo_sqlite, soap, xml, xmlwriter
PHP_INI_VALUES: assert.exception=1, zend.assertions=1
PHP_INI_VALUES: assert.exception=1, zend.assertions=1, error_reporting=E_ALL, display_errors=On

strategy:
fail-fast: false
Expand Down Expand Up @@ -186,7 +186,7 @@ jobs:
php-version: ${{ matrix.php-version }}
coverage: pcov
extensions: dom, json, libxml, mbstring, pdo_sqlite, soap, xml, xmlwriter
ini-values: assert.exception=1, zend.assertions=1
ini-values: assert.exception=1, zend.assertions=1, error_reporting=E_ALL, display_errors=On

- name: Determine composer cache directory
run: echo "COMPOSER_CACHE_DIR=$(./tools/composer config cache-dir)" >> $GITHUB_ENV
Expand Down Expand Up @@ -238,7 +238,7 @@ jobs:
php-version: ${{ matrix.php-version }}
coverage: pcov
extensions: dom, json, libxml, mbstring, pdo_sqlite, soap, xml, xmlwriter
ini-values: assert.exception=1, zend.assertions=1
ini-values: assert.exception=1, zend.assertions=1, error_reporting=E_ALL, display_errors=On

- name: Determine composer cache directory
run: echo "COMPOSER_CACHE_DIR=$(tools/composer config cache-dir)" >> $GITHUB_ENV
Expand Down

0 comments on commit b8b5940

Please sign in to comment.