Skip to content

jrencz/storybook-lity-story-height-repro

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

3 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

This repository reproduces problem which storybookjs/storybook#21174 attempts to fix.

How to test

  1. Prove it's now broken Run as-is (with 7.0.0-beta.53) in Safari

    npm ci && npm start
    1. Observe that only first line of the story is visible
    2. Click +/-. Observe that height of story is adjusted
  2. Reverse storybook and all @storybook/* to 7.0.0-beta.49 (last before storybookjs/storybook#21138)

    npm i --no-save storybook@7.0.0-beta.49 \
     @storybook/web-components-vite@7.0.0-beta.49 \
     @storybook/web-components@7.0.0-beta.49 \
     @storybook/addon-links@7.0.0-beta.49 \
     @storybook/addon-essentials@7.0.0-beta.49
    npm start
    1. Observe that the effect seen before is not present - all lines are shown
  3. Test storybookjs/storybook#21174

    1. Prepare working copy of storybook with fix

      cd code && yarn build components
    2. Copy content of code/ui/components/dist

    3. In this repo: reinstall 7.0.0-beta.53

      npm ci
    4. Replace ./node_modules/@storybook/components/dist with the copied one (index.js, index.mjs and index.d.ts will be replaced)

    5. run again

      npm start
      • Observe problem is gone: all lines are shown
      • You may play with both Zoom in/Zoom out controls of Story, and with component's own button to change size to confirm

Releases

No releases published

Packages

No packages published