Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis has been broken for a long time #377

Closed
mgol opened this issue Feb 10, 2016 · 5 comments
Closed

Travis has been broken for a long time #377

mgol opened this issue Feb 10, 2016 · 5 comments
Milestone

Comments

@mgol
Copy link
Member

mgol commented Feb 10, 2016

Travis tests have been broken for over 4 months: https://travis-ci.org/jquery/sizzle/builds. That's bad, especially that new commits have been landing since and we can't know if they didn't introduce regressions.

@gibson042
Copy link
Member

It's true, partly because of #362 and partly from the cross-window Sizzle.noConflict() testing (addressed by 087ba11) that I didn't notice through the noise of the former. I have been confirming fixes manually, and we all know how that goes.

Ideas and PRs welcome.

@mgol
Copy link
Member Author

mgol commented Feb 10, 2016

We reverted Karma to 0.12 so #362 shouldn't be an issue. We have timeouts in other browsers, updating karma-browserstack-launcher to the newest release might fix this problem; I wanted to do that & check but then I hit this noConflict issue. Perhaps we can re-try that now (unless the newest karma-browserstack-launcher requires Karma 0.13 to run but it doesn't seem to be the case).

@gibson042
Copy link
Member

@mgol I've done what I can, and we're back to timeouts galore: https://travis-ci.org/jquery/sizzle/builds/108436309

Upgrading karma may help things, and v0.13.19 includes a socket.io-client that works with IE<8, but I guess we're still waiting for forceJSONP.

@dignifiedquire
Copy link

I just released 0.13.20 which ships with forceJSONP

gibson042 added a commit that referenced this issue Feb 14, 2016
@gibson042 gibson042 added this to the Next milestone Feb 14, 2016
@gibson042
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants