Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable: Modified to allow jquery objects as handles #1445

Closed
wants to merge 1 commit into from

Conversation

tjvantoll
Copy link
Member

Custom handlers did not work as jquery objects (outside the resizable element)

Fixes #9658

@@ -195,7 +196,11 @@ $.widget("ui.resizable", $.ui.mouse, {

this._renderAxis = function(target) {

var i, axis, padPos, padWrapper;
var i, axis, padPos, padWrapper, mouseDownHandlers = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

@tjvantoll
Copy link
Member Author

@patrixd Are you interested in continuing this and implementing @scottgonzalez's suggestions? Otherwise I can go through them and patch this up.

Custom handlers did not work as jquery objects (outside the resizable element)

Fixes #9658
Closes jquerygh-1445
@tjvantoll
Copy link
Member Author

@scottgonzalez I agreed with all of your suggestions and just pushed updates. Much cleaner.

@patrixd
Copy link
Contributor

patrixd commented Feb 28, 2015

Thanks so much @tjvantoll for your support. I did not have time this week at work to push the updates.

@scottgonzalez
Copy link
Member

Looks good.

@tjvantoll tjvantoll closed this in 18e301f Mar 3, 2015
scottgonzalez pushed a commit that referenced this pull request Mar 10, 2015
Custom handlers did not work as jquery objects (outside the resizable element)

Fixes #9658
Closes gh-1445
(cherry picked from commit 18e301f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants