-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion: fixes #9264 #1287
Closed
JacquesPerrault
wants to merge
22
commits into
jquery:master
from
JacquesPerrault:9264-accordion-heightStyle-auto-has-problems
Closed
Accordion: fixes #9264 #1287
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
94831fe
Accordion: heightStyle: 'auto' has problems
JacquesPerrault e4c53e8
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault 0780604
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault f443e2a
Accordion: heightStyle: 'auto' has problems
JacquesPerrault db4889b
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault e0d8dfa
Accordion: heightStyle: 'auto' has problems
JacquesPerrault 157cddd
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault 26a7542
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault b904f94
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault ce7522f
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault d2b763b
Accordion: heightStyle: 'auto' has problems
JacquesPerrault e414a37
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault 827234a
Accordion: heightStyle: 'auto' has problems
JacquesPerrault 3dfbcfa
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault d7fedbf
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault a2b75b5
Accordion: heightStyle: 'auto' has problems
JacquesPerrault 0340b91
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault b0ed846
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault b00f70b
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault 11f0dd2
Merge branch 'master' of git://github.com/jquery/jquery-ui into 9264-…
JacquesPerrault 23167de
Accordion: heightStyle: 'auto' has problems
JacquesPerrault 192b7b0
Accordion: heightStyle: 'auto' has problems
JacquesPerrault File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-box
andpadding-box
need different adjustments.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I separated
padding-box
, but only Firefox recognizes it, and it still causes text below the accordion to jump. I know that I need to exclude padding, but I can't seem to get it right.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I might be on board with @mikesherov now; let's just handle
border-box
andcontent-box
.