2nd Reopen - Suggested fix for #8740 #1053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0 - Tooltip: Does not hide consistently with dynamically loaded content.
|
This looks good to me. There are some jshint issues with your second test, but we might be able to just drop that one. |
|
@scottgonzalez Any concerns with landing this? @mziech addressed your concerns from #992 and I verified this indeed fixes the issue. @jzaefferer you may also want to take a look. |
tekumara
added a commit
to ebi-gene-expression-group/atlas
that referenced
this pull request
Nov 7, 2013
…ery-ui that includes pull-request jquery/jquery-ui#1053
| var element = $( "#tooltipped1" ).tooltip({ | ||
| content: function( response ) { | ||
| element.trigger( "mouseleave" ); | ||
| setTimeout(function () { |
There was a problem hiding this comment.
No space between function and ().
Conflicts: ui/tooltip.js
…ot hide consistently with dynamically loaded content.
…de consistently with dynamically loaded content.
|
Ok, I incorporated the recent change request and updated the pull request. |
|
Any idea when this will be in a release? It fixes the issue for me of multiple tooltips showing when I have AJAX content. |
|
Bump. |
scottgonzalez
pushed a commit
to scottgonzalez/jquery-ui
that referenced
this pull request
Feb 24, 2015
Fixes #8740 Closes jquerygh-1053
|
Yay progress 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip: Register event handlers before content is loaded. Fixes #8740 - Tooltip: Does not hide consistently with dynamically loaded content.
See http://bugs.jqueryui.com/ticket/8740
This pull request incorporates all suggested changes from #992 including the fixed commit message.