Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker, Next month button tooltip encoding issue? #2048

Closed
Tracked by #2100
adalid-1 opened this issue Feb 7, 2022 · 7 comments
Closed
Tracked by #2100

Datepicker, Next month button tooltip encoding issue? #2048

adalid-1 opened this issue Feb 7, 2022 · 7 comments
Assignees
@fnagel
Labels
Behavior different from 1.12 Bug Localization
Milestone
1.13.2

Comments

@adalid-1
Copy link
Contributor

adalid-1 commented Feb 7, 2022 •
edited
Loading

In some languages there is some text after the word "Next" in whatever language. In my case it is swedish and the tooltip is this: Nästa» but the arrow there is in text not as an arrow. Same issue with previous month.

Added a picture of the same problem in chinese and for replication you can check here:
https://jqueryui.com/datepicker/#localization

d3dfef2e-09ff-4d3d-af6a-4cc56dee3ed3
@adalid-1 adalid-1 changed the title Datepicker, Next month button tooltip Datepicker, Next month button tooltip encoding issue? Feb 7, 2022
@mgol
Copy link
Member

mgol commented Feb 8, 2022

Thanks for the report. Does the issue you describe exist when jQuery UI 1.12.1 is used or only with jQuery UI 1.13.0 or newer?

@mgol mgol added the Needs info label Feb 8, 2022
@adalid-1
Copy link
Contributor Author

adalid-1 commented Feb 9, 2022

I tried reverting this package to version 1.12.1 in our project and the problem seemed to exist there as well.

@mgol
Copy link
Member

mgol commented Feb 9, 2022

Thanks for the report. Since the issue is already in 1.12, given limited team resources it's not likely to be fixed by the UI team; see the project status at https://blog.jqueryui.com/2021/10/jquery-maintainers-update-and-transition-jquery-ui-as-part-of-overall-modernization-efforts/.

We'd welcome a PR if it's not too complex, though.

@adalid-1
Copy link
Contributor Author

Alright, I can look into it. Thank you for your time so far.

@adalid-1
Copy link
Contributor Author

adalid-1 commented Feb 11, 2022 •
edited
Loading

It would seem that the arrows « and » in the tooltip is removed in english french and some languages.
Maybe I could just make a PR where I remove it from other languages as well? Fixing support for that character might prove trickier/ be more risky?

Please redirect me if I should be asking someone/somewhere else.

adalid-1 pushed a commit to adalid-1/jquery-ui that referenced this issue Feb 11, 2022
@BinaryBeast101
Datepicker: removed arrow symbols from next and previous month hover …
16a0124 
…text in swedish

Fixes jquery#2048
adalid-1 pushed a commit to adalid-1/jquery-ui that referenced this issue Feb 11, 2022
@BinaryBeast101
Datepicker: removed symbols from next/prev month tooltip
2baed25 
Fixes jquery#2048
@adalid-1 adalid-1 mentioned this issue Feb 11, 2022
Closed
adalid-1 added a commit to adalid-1/jquery-ui that referenced this issue Feb 11, 2022
@adalid-1 @BinaryBeast101
Datepicker: removed symbols from next/prev month tooltip
cefc4dc 
Fixes jquery#2048
adalid-1 added a commit to adalid-1/jquery-ui that referenced this issue Feb 15, 2022
@adalid-1 @BinaryBeast101
Datepicker: localization removed symbols
4ce4bac 
Removed arrow symbols for next/previous month in all languages

Ref jquery#2048
adalid-1 added a commit to adalid-1/jquery-ui that referenced this issue Feb 15, 2022
@adalid-1 @BinaryBeast101
Datepicker: localization removed symbols
c03a030 
Removed in some languages i missed first time

Ref jquery#2048
@alecpl
Copy link

alecpl commented Feb 19, 2022 •
edited
Loading

The same issue with Polish language and jQuery-UI 1.13.1. Please, fix it. The same with Prev button.

@mgol
Copy link
Member

mgol commented Mar 1, 2022

This is a regression from 1.12.1 so I'm updating the issue labels and setting the milestone.

@mgol mgol added this to the 1.13.2 milestone Mar 1, 2022
@fnagel fnagel self-assigned this Jul 8, 2022
fnagel pushed a commit to fnagel/jquery-ui that referenced this issue Jul 8, 2022
@adalid-1 @fnagel
Datepicker: Remove symbols in localization
c11740d 
Ref jquery#2048
Fixes jquery#2048
fnagel added a commit to fnagel/jquery-ui that referenced this issue Jul 8, 2022
@fnagel
Datepicker: Remove symbols in localization
931c141 
Follow-up to c11740d

Ref jquery#2048
@fnagel fnagel mentioned this issue Jul 8, 2022
Merged
8 tasks
fnagel pushed a commit to fnagel/jquery-ui that referenced this issue Jul 9, 2022
@adalid-1 @fnagel
Datepicker: Remove symbols in localization
dfff5e7 
Fixes jquerygh-2048
Closes jquerygh-2050
Ref jquerygh-2067
fnagel added a commit to fnagel/jquery-ui that referenced this issue Jul 9, 2022
@fnagel
Datepicker: Remove symbols in localization
0ccafc7 
Follow-up to dfff5e7

Fixes jquerygh-2048
Closes jquerygh-2050
fnagel added a commit to fnagel/jquery-ui that referenced this issue Jul 9, 2022
@fnagel
Datepicker: Add missing localization for prevText and nextText
5cc4b3f 
Fixes jquerygh-2048
Closes jquerygh-2050
mgol pushed a commit to fnagel/jquery-ui that referenced this issue Jul 14, 2022
@adalid-1 @mgol
Datepicker: Remove symbols in localization
6bcf28b 
Fixes jquerygh-2048
Closes jquerygh-2050
Ref jquerygh-2067
mgol pushed a commit to fnagel/jquery-ui that referenced this issue Jul 14, 2022
@fnagel @mgol
Datepicker: Remove symbols in localization
4556411 
Follow-up to dfff5e7

Fixes jquerygh-2048
Closes jquerygh-2050
mgol pushed a commit to fnagel/jquery-ui that referenced this issue Jul 14, 2022
@fnagel @mgol
Datepicker: Add missing localization for prevText and nextText
a469baa 
Fixes jquerygh-2048
Closes jquerygh-2050
Closes jquerygh-2100
@mgol mgol closed this as completed in 3126e12 Jul 14, 2022
mgol pushed a commit that referenced this issue Jul 14, 2022
@fnagel @mgol
Datepicker: Remove symbols in localization
218c6af 
Follow-up to dfff5e7

Fixes gh-2048
Closes gh-2050
mgol pushed a commit that referenced this issue Jul 14, 2022
@fnagel @mgol
Datepicker: Add missing localization for prevText and nextText
395aa7d 
Fixes gh-2048
Closes gh-2050
Closes gh-2100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnagel fnagel

Labels
Behavior different from 1.12 Bug Localization
Milestone
1.13.2
4 participants
@fnagel @alecpl @mgol @adalid-1