Skip to content

Commit

Permalink
fixup! address PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
timmywil committed Mar 19, 2024
1 parent 2d4424e commit ba3c9f8
Show file tree
Hide file tree
Showing 13 changed files with 5,814 additions and 8,439 deletions.
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.{json,yml}]
[*.{yml}]
indent_style = space
indent_size = 2
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Browserstack
name: Browserstack (Core 3.x)

on:
push:
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
-v --browserstack "${{ matrix.BROWSER }}" \
--jquery-migrate dev --jquery-migrate min \
--jquery 3.x-git --jquery 3.x-git.min --jquery 3.x-git.slim --jquery 3.x-git.slim.min \
--jquery 3.7.0 --jquery 3.7.0.slim --jquery 3.6.4 --jquery 3.6.4.slim \
--jquery 3.7.1 --jquery 3.7.1.slim --jquery 3.6.4 --jquery 3.6.4.slim \
--jquery 3.5.1 --jquery 3.5.1.slim --jquery 3.4.1 --jquery 3.4.1.slim \
--jquery 3.3.1 --jquery 3.3.1.slim --jquery 3.2.1 --jquery 3.2.1.slim \
--jquery 3.1.1 --jquery 3.1.1.slim --jquery 3.0.0 --jquery 3.0.0.slim \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/browserstack-git.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Browserstack (git)
name: Browserstack (Core git)

on:
push:
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fail-fast: false
matrix:
MIGRATE_VERSION: ["min"]
JQUERY_VERSION: ["3.x-git.min", "3.x-git.slim.min"]
JQUERY_VERSION: ["git.min", "git.slim.min", "3.x-git.min", "3.x-git.slim.min"]
include:
- MIGRATE_VERSION: "esmodules"
JQUERY_VERSION: "3.x-git.slim.min"
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
fail-fast: false
matrix:
MIGRATE_VERSION: ["min"]
JQUERY_VERSION: ["3.x-git.min", "3.x-git.slim.min"]
JQUERY_VERSION: ["git.min", "git.slim.min", "3.x-git.min", "3.x-git.slim.min"]
steps:
- name: Checkout
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Expand All @@ -72,4 +72,7 @@ jobs:
run: npm install

- name: Run tests
run: npm run test:safari -- --jquery-migrate=${{ matrix.MIGRATE_VERSION }} --jquery=${{ matrix.JQUERY_VERSION }}
run: |
npm run test:safari -- \
--jquery-migrate=${{ matrix.MIGRATE_VERSION }} \
--jquery=${{ matrix.JQUERY_VERSION }}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ The following table indicates which jQuery Migrate versions can be used with whi
In your web page, load this plugin *after* the script tag for jQuery, for example:

```html
<script src="https://code.jquery.com/jquery-3.7.0.js"></script>
<script src="https://code.jquery.com/jquery-3.7.1.js"></script>
<script src="https://code.jquery.com/jquery-migrate-3.4.1.js"></script>
```

Expand Down
Loading

0 comments on commit ba3c9f8

Please sign in to comment.