Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document jQuery.ready #983

Merged
merged 1 commit into from
Mar 22, 2017
Merged

Document jQuery.ready #983

merged 1 commit into from
Mar 22, 2017

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Sep 20, 2016

Also:

  • Categorise jQuery.holdReady in events/document-loading,
    to match ready() and jQuery.ready.promise().
  • Categorise jQuery.holdReady in properties/global-jquery-object-properties,
    to match jQuery.fx.off() and jQuery.ready.promise().

Fixes #205

@Krinkle
Copy link
Member Author

Krinkle commented Sep 20, 2016

(Replying to now-closed pull #530)

@dmethvin Should this be documented as jQuery.ready or jQuery.ready.then? I assume the former. However we don't currently have an entry at Types for a pure "thenable". I.e. something that is not itself a $.Deferred, $.Deferred#promise or native Promise, but only returns one after calling .then().

@dmethvin
Copy link
Member

@Krinkle Yep, it's jQuery.ready and I think we need to create a Thenable type.

@dmethvin dmethvin mentioned this pull request Oct 5, 2016
21 tasks
@Krinkle
Copy link
Member Author

Krinkle commented Jan 23, 2017

Blocked on #906. (Add Thenable type, and update jQuery.when as receiving it in addition to Promise/jQuery.Deferred)

Also categorise jQuery.holdReady in events/document-loading and
properties/global-jquery-object-properties, to match jQuery.ready.

Fixes #205
@Krinkle
Copy link
Member Author

Krinkle commented Mar 21, 2017

Unblocked! Rebased for #1026 (landed).

@dmethvin Could you re-review?

Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, we need to mark holdReady as deprecated but there's already a ticket for that in #972 . Thanks!

@mgol mgol merged commit 7f12994 into jquery:master Mar 22, 2017
@Krinkle Krinkle deleted the jq-ready branch March 22, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants