refactor(parse-iso-date): Convert to TypeScript #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted from: https://github.com/csnover/js-iso8601/blob/master/tests/test.js NOTE: Many of these tests do not currently pass because of modifications that have been made to parseIsoDate. Those changes include (but probably aren't limited to): - The regex has been modified to add more "?" conditionals to make the parsing more forgiving - Times that lack a time zone specifier are treated as local time
All tests now pass with the current implementation of parseIsoDate.
It was the only JS file remaining in the repo, it was also written in an old, difficult to read style of JavaScript The functionality remains identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The poor
parseIsoDateutil was the only file in the repo that hadn't been converted over to TypeScript back in 2020. In addition, it was written in a way that was hard to read and harder to understand. It also had the linter disabled for the entire file.This pull request aims to fix all those issues, while maintaining exactly the same functionality.
To ensure the same functionality, before making any changes I ported over the tests from the original source of the
parseIsoDatefunction. Many of those tests no longer passed because of previous changes made to the function, but I modified them to match the module's current functionality. With the tests in place, I was then able to refactor the module and ensure that the functionality remained identical.