Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StringSchema.matches options optional #1166

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Make StringSchema.matches options optional #1166

merged 1 commit into from
Dec 10, 2020

Conversation

bespokebob
Copy link
Contributor

@bespokebob bespokebob commented Dec 10, 2020 •
edited
Loading

The second parameter to matches() should be optional.

jquense
jquense reviewed Dec 10, 2020
View reviewed changes
src/string.ts Outdated Show resolved Hide resolved
@bespokebob
Make StringSchema.matches options optional
8cf6694 
The second parameter to matches() should be optional.
@bespokebob bespokebob force-pushed the matches-options-optional branch from 6ff9f2d to 8cf6694 Compare December 10, 2020 16:52
@jquense jquense merged commit b53e5f2 into jquense:master Dec 10, 2020
@jquense
Copy link
Owner

jquense commented Dec 10, 2020

thanks!

@dependabot dependabot bot mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bespokebob @jquense