Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doubleClick handlers on empty slots #570

Closed
wants to merge 2 commits into from

Conversation

alxmiron
Copy link
Contributor

@alxmiron alxmiron commented Oct 3, 2017

This PR is a part of #563 issue

New:

  • onDoubleClickSlot handler
    Callback fired when empty calendar cell was clicked twice.
    (date: Date, e: SyntheticEvent) => any
  • onDoubleClickAllDaySlot handler
    Callback fired when empty calendar all-day cell was clicked twice.
    (date: Date, e: SyntheticEvent) => any

Changes are similar to onSelectSlot handler

@alxmiron alxmiron changed the title #563-2 doubleClick handlers on empty slots Add doubleClick handlers on empty slots Oct 3, 2017
@jquense
Copy link
Owner

jquense commented Oct 3, 2017

On selectSlot already handles the click case, maybe we can extend that for dblClick without the pointer-events? I want to avoid that css if possible in the core library for browser support. I'm less concerned about it in addons since they are additions.

@alxmiron
Copy link
Contributor Author

alxmiron commented Oct 3, 2017

Ok, I'll look into Selection object, what we can do with it.
Note, that pointer-events have good browser support

@alxmiron
Copy link
Contributor Author

alxmiron commented Oct 4, 2017

@jquense See another solution in #575

@alxmiron alxmiron closed this Nov 7, 2017
@alxmiron alxmiron deleted the feature/563-2 branch November 7, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants