Avoid passing unnecesary props

jquense · May 24, 2017 · 1d33fcf · 1d33fcf
1 parent cc71cd2
commit 1d33fcf
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 14 deletions.
diff --git a/.gitignore b/.gitignore
@@ -30,3 +30,6 @@ node_modules
 
 # Webstorm ide files
 .idea
+
+# Mac OS X
+.DS_Store
diff --git a/src/BackgroundCells.js b/src/BackgroundCells.js
@@ -65,8 +65,7 @@ class BackgroundCells extends React.Component {
             <Wrapper
               key={index}
               value={date}
-              isFirstInRange={index === 0}
-              isLastInRange={index === range.length - 1}
+              range={range}
             >
               <div
                 style={segStyle(1, range.length)}

diff --git a/src/BackgroundWrapper.js b/src/BackgroundWrapper.js
@@ -9,8 +9,8 @@ class BackgroundWrapper extends React.Component {
 
 BackgroundWrapper.propTypes = {
   children: PropTypes.element,
-  isFirstInRange: PropTypes.bool,
-  isLastInRange: PropTypes.bool,
+  value: PropTypes.instanceOf(Date),
+  range: PropTypes.arrayOf(PropTypes.instanceOf(Date))
 }
 
 export default BackgroundWrapper;
diff --git a/src/DateContentRow.js b/src/DateContentRow.js
@@ -104,8 +104,6 @@ class DateContentRow extends React.Component {
       date,
       key: `header_${index}`,
       style: segStyle(1, range.length),
-      isFirstInRange: index === 0,
-      isLastInRange: index === range.length - 1,
       className: cn(
         'rbc-date-cell',
         dates.eq(date, this.props.now, 'day') && 'rbc-now', // FIXME use props.now

diff --git a/src/DateHeader.js b/src/DateHeader.js
@@ -18,10 +18,7 @@ DateHeader.propTypes = {
   date: PropTypes.instanceOf(Date),
   drillDownView: PropTypes.string,
   onDrillDown: PropTypes.func,
-  isFirstInRange: PropTypes.bool,
-  isLastInRange: PropTypes.bool,
-  isOffRange: PropTypes.bool,
-  isCurrent: PropTypes.bool
+  isOffRange: PropTypes.bool
 }
 
 export default DateHeader
diff --git a/src/Month.js b/src/Month.js
@@ -194,7 +194,7 @@ class MonthView extends React.Component {
     )
   }
 
-  readerDateHeading = ({ date, className, isFirstInRange, isLastInRange, ...props }) => {
+  readerDateHeading = ({ date, className, ...props }) => {
     let {
       date: currentDate,
       getDrilldownView,
@@ -221,10 +221,7 @@ class MonthView extends React.Component {
           label={label}
           date={date}
           drilldownView={drilldownView}
-          isFirstInRange={isFirstInRange}
-          isLastInRange={isLastInRange}
           isOffRange={isOffRange}
-          isCurrent={isCurrent}
           onDrillDown={e => this.handleHeadingClick(date, drilldownView, e)} />
       </div>
     )