Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force controlled on combobox #284

Merged
merged 2 commits into from
Nov 15, 2023
Merged

fix: force controlled on combobox #284

merged 2 commits into from
Nov 15, 2023

Conversation

jqpe
Copy link
Owner

@jqpe jqpe commented Nov 15, 2023

Fixes the following error introduced in #279:

A component is changing from uncontrolled to controlled. This may be caused by the value changing from undefined to a defined value, which should not happen.

Closes the following Sentry issue:
https://junat.sentry.io/share/issue/b7e154ebbaf74ced91b31be9c221077f/

@jqpe jqpe added the bug Something isn't working label Nov 15, 2023
Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
junat-live ✅ Ready (Inspect) Visit Preview Nov 15, 2023 7:17am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 7:17am

@vercel vercel bot temporarily deployed to Preview – storybook November 15, 2023 07:14 Inactive
Copy link

📦 Next.js Bundle Analysis for junat.live

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 168.41 KB (🟢 -14.97 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/_error 675 B (🟡 +6 B) 169.07 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2bc046) 77.23% compared to head (8b998d7) 78.24%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   77.23%   78.24%   +1.00%     
==========================================
  Files         105      105              
  Lines        1797     1797              
  Branches      260      260              
==========================================
+ Hits         1388     1406      +18     
+ Misses        323      310      -13     
+ Partials       86       81       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vercel vercel bot temporarily deployed to Preview – junat-live November 15, 2023 07:17 Inactive
@jqpe jqpe merged commit 555a181 into main Nov 15, 2023
9 checks passed
@jqpe jqpe deleted the jqpe/jun-232 branch November 15, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant