Ports back some more tests

jqno · Dec 5, 2024 · 7da2273 · 7da2273
1 parent 17871bc
commit 7da2273
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 24 deletions.
diff --git a/.../src/test/java/nl/jqno/equalsverifier/integration/extended_contract/GenericTypesTest.java b/.../src/test/java/nl/jqno/equalsverifier/integration/extended_contract/GenericTypesTest.java
@@ -167,6 +167,30 @@ public int hashCode() {
         }
     }
 
+    static final class Generic<T> {
+
+        private final T t;
+
+        public Generic(T t) {
+            this.t = t;
+        }
+
+        @Override
+        public boolean equals(Object obj) {
+            if (!(obj instanceof Generic)) {
+                return false;
+            }
+            @SuppressWarnings("unchecked")
+            Generic<T> other = (Generic<T>) obj;
+            return Objects.equals(t, other.t);
+        }
+
+        @Override
+        public int hashCode() {
+            return Objects.hash(t);
+        }
+    }
+
     static final class JavaGenericTypeContainer {
 
         private final Optional<Point> optional;
@@ -218,30 +242,6 @@ public String toString() {
         }
     }
 
-    static final class Generic<T> {
-
-        private final T t;
-
-        public Generic(T t) {
-            this.t = t;
-        }
-
-        @Override
-        public boolean equals(Object obj) {
-            if (!(obj instanceof Generic)) {
-                return false;
-            }
-            @SuppressWarnings("unchecked")
-            Generic<T> other = (Generic<T>) obj;
-            return Objects.equals(t, other.t);
-        }
-
-        @Override
-        public int hashCode() {
-            return Objects.hash(t);
-        }
-    }
-
     static final class ListContainer {
 
         private final List<Point> list;

diff --git a/.../nl/jqno/equalsverifier/integration/operational/ConfiguredEqualsVerifierMultipleTest.java b/.../nl/jqno/equalsverifier/integration/operational/ConfiguredEqualsVerifierMultipleTest.java
@@ -156,6 +156,27 @@ public void individuallySuppressedWarningsAreNotAddedGlobally() {
     public void individuallyAddedPrefabValuesAreNotAddedGlobally() {
         ConfiguredEqualsVerifier ev = EqualsVerifier.configure();
 
+        // should succeed
+        ev
+            .forClasses(RecursiveTypeContainer.class, A.class)
+            .withPrefabValues(
+                RecursiveType.class,
+                new RecursiveType(null),
+                new RecursiveType(new RecursiveType(null))
+            )
+            .verify();
+
+        // PrefabValues are not added to configuration, so should fail
+        ExpectedException
+            .when(() -> ev.forClasses(RecursiveTypeContainer.class, A.class).verify())
+            .assertFailure()
+            .assertMessageContains("Recursive datastructure");
+    }
+
+    @Test
+    public void individuallyAddedGenericPrefabValuesAreNotAddedGlobally() {
+        ConfiguredEqualsVerifier ev = EqualsVerifier.configure();
+
         // should succeed
         ev
             .forClasses(SingleGenericContainerContainer.class, A.class)

diff --git a/...va/nl/jqno/equalsverifier/integration/operational/ConfiguredEqualsVerifierSingleTest.java b/...va/nl/jqno/equalsverifier/integration/operational/ConfiguredEqualsVerifierSingleTest.java
@@ -117,6 +117,27 @@ public void individuallySuppressedWarningsAreNotAddedGlobally() {
     public void individuallyAddedPrefabValuesAreNotAddedGlobally() {
         ConfiguredEqualsVerifier ev = EqualsVerifier.configure();
 
+        // should succeed
+        ev
+            .forClass(RecursiveTypeContainer.class)
+            .withPrefabValues(
+                RecursiveType.class,
+                new RecursiveType(null),
+                new RecursiveType(new RecursiveType(null))
+            )
+            .verify();
+
+        // PrefabValues are not added to configuration, so should fail
+        ExpectedException
+            .when(() -> ev.forClass(RecursiveTypeContainer.class).verify())
+            .assertFailure()
+            .assertMessageContains("Recursive datastructure");
+    }
+
+    @Test
+    public void individuallyAddedGenericPrefabValuesAreNotAddedGlobally() {
+        ConfiguredEqualsVerifier ev = EqualsVerifier.configure();
+
         // should succeed
         ev
             .forClass(SingleGenericContainerContainer.class)