add skip/2 as the counterpart to limit/2 #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
add-skip-2
branch
4 times, most recently
from
f758f3e
to
03fa79c
Compare
wader
added a commit
to wader/jaq
that referenced
this pull request
Sep 24, 2024
`[[]] | implode` crash was fixed in 1.7 by jqlang/jq#2646 `[limit(0; 1, 2, 3)]` yielding 1,2 instead of nothing fixed in 1.7 by jqlang/jq#2316 `limit/2` will throw error on negative limit once jqlang/jq#3181 is merged
|
Any comments from another maintainer? |
|
Please merge! Thank you! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
skip/2as the counterpart oflimit/2. I also changed the behavior oflimit/2with negative count to emit an error, likenth/2does. Also, I redefinednth/2usingskip/2to minimize the impact of growth of builtin filters.