Move RGBLight animations to data driven (qmk#21635)

jpskenn · Nov 5, 2023 · 1eaeed8 · 1eaeed8
1 parent 82524a8
commit 1eaeed8
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/keyboards/nora/v01/config.h b/keyboards/nora/v01/config.h
@@ -23,8 +23,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
   #define RGBLIGHT_LAYERS
   #define RGBLIGHT_LAYERS_OVERRIDE_RGB_OFF // Overriding RGB Lighting on/off status
   #define RGBLIGHT_LAYERS_RETAIN_VAL // Keeps RGB values between lighting layer changes
-  #define RGBLIGHT_ANIMATIONS
-  #define RGBLIGHT_EFFECT_TWINKLE
 
 /* External EEPROM & Dynamic keymap */
 // Use 24LC64 EEPROM

diff --git a/keyboards/nora/v01/info.json b/keyboards/nora/v01/info.json
@@ -22,7 +22,13 @@
         "led_count": 16,
         "max_brightness": 240,
         "saturation_steps": 8,
-        "brightness_steps": 8
+        "brightness_steps": 8,
+        "animations": {
+            "breathing": true,
+            "rainbow_mood": true,
+            "rainbow_swirl": true,
+            "twinkle": true
+        }
     },
     "layouts": {
         "LAYOUT": {

diff --git a/keyboards/nora/v03/config.h b/keyboards/nora/v03/config.h
@@ -29,7 +29,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
   #define RGBLIGHT_LAYERS
   #define RGBLIGHT_LAYERS_OVERRIDE_RGB_OFF // Overriding RGB Lighting on/off status
   #define RGBLIGHT_LAYERS_RETAIN_VAL // Keeps RGB values between lighting layer changes
-  #define RGBLIGHT_EFFECT_RGB_TEST
 #endif
 
 /* External EEPROM */

diff --git a/keyboards/nora/v03/info.json b/keyboards/nora/v03/info.json
@@ -23,13 +23,15 @@
         "sat_steps": 8,
         "speed_steps": 8,
         "val_steps": 8,
-        "max_brightness": 150
     },
     "rgblight": {
         "led_count": 71,
         "max_brightness": 150,
         "saturation_steps": 8,
-        "brightness_steps": 8
+        "brightness_steps": 8,
+        "animations": {
+            "tgb_test": true
+        }
     },
     "layouts": {
         "LAYOUT": {