Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Anchor coding, Tag coding and redundancy auto-aliasing #428

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lynchsft
Copy link

  • Yams is able to encode and decode Anchors via YamlAnchorProviding, and
    YamlAnchorCoding.
    #125

  • Yams is able to encode and decode Tags via YamlTagProviding
    and YamlTagCoding.
    #265

  • Yams is able to detect redundant structes and automaticaly
    alias them during encoding via RedundancyAliasingStrategy

@lynchsft
Copy link
Author

@jpsim is it intended configuration that the workflows won't run without a maintainer approving? I would have loved to validated that all builds succeeded before bugging you. 🙏🏻

@lynchsft
Copy link
Author

lynchsft commented Oct 9, 2024

I see the failed checks and will work to resolve them. :) 🙏🏻

@lynchsft
Copy link
Author

The pod lib lint failed because of a workflow/host misconfiguration.

ERROR | [visionOS] unknown: Encountered an unknown error (Could not find a xrossimulator (valid values: ios, tvos, watchos). Ensure that Xcode -> Window -> Devices has at least onexros simulator listed or otherwise add one.

IIRC xros was a preview-name of VisionOS.

Suggestions how to proceed with this failure?

(I'm gonna push fixes to the linting errors next.)

@lynchsft
Copy link
Author

I believe all the linting errors have been resolved. :)

@lynchsft
Copy link
Author

The Jazzy warnings should be handled now. All that remains is the visionOS simulator on macOS-14. See above comment for error message. Suggestions?

@lynchsft
Copy link
Author

lynchsft commented Oct 21, 2024

I asked xcodebuild to download this missing runtime. As this takes about ~3 minutes in each run, I also parallelized the cocoa pods platforms.

I think all the checks should pass now. :)

@lynchsft
Copy link
Author

lynchsft commented Nov 8, 2024

I apologize. Very belatedly I realize that I should have PR'ed this onto my fork before PR''ing it here.
This is the same changeset/branch passing in my fork: lynchsft#3

Ready for review. 🤦🏼‍♀️

@jpsim
Copy link
Owner

jpsim commented Nov 18, 2024

Thank you very much for the PR, Adora and for fixing the unrelated CocoaPods CI issue.

I'll be taking a close look at this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants