Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: support rules_swift 2.x #420

Merged

Conversation

luispadron
Copy link
Collaborator

rules_swift 2.x increases the compatibility_level so we need to declare we support up-to this new level.

@jpsim
Copy link
Owner

jpsim commented Jun 30, 2024

Thanks! Can you please update the CI workflow file to include this file so CI runs when it’s modified? https://github.com/jpsim/Yams/blob/main/.github/workflows/bazel.yml

@luispadron luispadron force-pushed the luis/declare-max-compatibility-2-for-rules_swift branch from 73d3354 to 76b2529 Compare June 30, 2024 17:15
@luispadron
Copy link
Collaborator Author

Updated! Would you also own sourcekitten_com_github_drmohundro_SWXMLHash? I can't find the repo with that file but we'll need to make a similar change there if it's using rules_swift

@jpsim
Copy link
Owner

jpsim commented Jun 30, 2024

I think that’s defined in https://github.com/jpsim/SourceKitten

@jpsim jpsim merged commit 709e4f2 into jpsim:main Jun 30, 2024
8 checks passed
jpsim added a commit to tonyarnold/Yams that referenced this pull request Jul 10, 2024
jpsim added a commit to futurejones/Yams that referenced this pull request Jul 10, 2024
* main:
  Add support for Android (jpsim#421)
  GitHub Actions workflow fixes (jpsim#422)
  add os(visionOS) support (jpsim#418)
  Bazel: support rules_swift 2.x (jpsim#420)
  Bump rexml from 3.2.5 to 3.2.8
tejassharma96 added a commit to tejassharma96/Yams that referenced this pull request Jul 10, 2024
# By JP Simard (3) and others
# Via GitHub
* upstream/main:
  Require Swift 5.7 or later (jpsim#424)
  Add empty changelog section
  Release 5.1.3
  add support for riscv64 (jpsim#419)
  Add support for Android (jpsim#421)
  GitHub Actions workflow fixes (jpsim#422)
  add os(visionOS) support (jpsim#418)
  Bazel: support rules_swift 2.x (jpsim#420)
  Bump rexml from 3.2.5 to 3.2.8

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants