Layout of other judges scores is good

Switched to a monospaced font to ensure that the columns line up. Issue #1129
jpschewe · Jan 4, 2025 · e1b6d4d · e1b6d4d
1 parent a8e563d
commit e1b6d4d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/main/web/subjective/subjective-ui.js b/src/main/web/subjective/subjective-ui.js
@@ -819,8 +819,6 @@ function populateScoreSummary() {
                 if (subjective_module.isScoreCompleted(otherScore)) {
                     const otherComputedScore = subjective_module.computeScore(otherScore);
                     teamOtherJudgeScores.set(otherJudgeId, `${otherComputedScore} 1`);
-                } else {
-                    teamOtherJudgeScores.set(otherJudgeId, "&nbsp;");
                 }
             }
         }
@@ -959,11 +957,13 @@ function populateScoreSummary() {
             const otherScoreBlock = document.createElement("span");
             rightBlock.appendChild(otherScoreBlock);
 
+            const otherJudgeIdLength = otherJudgeId.length;
             const otherScoreText = teamOtherJudgeScores.get(otherJudgeId);
             if (otherScoreText) {
-                otherScoreBlock.innerHTML = centerText(otherScoreText, otherJudgeId.length);
+                otherScoreBlock.innerHTML = centerText(otherScoreText, otherJudgeIdLength);
             } else {
-                otherScoreBlock.innerHTML = "&nbsp;".repeat(otherJudgeId.length);
+                const str = "&nbsp;".repeat(otherJudgeIdLength);
+                otherScoreBlock.innerHTML = str;
             }
             otherScoreBlock.classList.add("score-summary-right-elements");
             otherScoreBlock.classList.add("other-judge");

diff --git a/src/main/web/subjective/subjective.css b/src/main/web/subjective/subjective.css
@@ -171,5 +171,11 @@ footer button {
 
 #enter-score-note-button {
     background-color: purple;
-    color: white;    
+    color: white;
 }
+
+/* make sure the other judge columns line up */
+.other-judge {
+    font-family: monospace;
+    font-size: larger;
+}