Downloading onto a different drive throws an EXDEV error #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2014 20:27
The tmpdir is now placed directly in the cwd. After unzipping the tmp folder gets rimraf'ed (rm -rf).
|
Cool. Remove |
|
Done! Didn't test though, but the change seemed pretty straight forward. If possible please patch or minor update this repo so I can update Headstart's npm deps accordingly in a later update. |
jprichardson
added a commit
that referenced
this pull request
Jun 17, 2014
Downloading onto a different drive throws an EXDEV error
|
Published. Thanks again. |
|
No problem. Thank you also for the great module! 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As posted on the Headstart issues, downloading files into a directory on an external drive will throw an EXDEV error. This PR puts the tmp folder directly inside of the working directory (cwd) and cleans up afterwards through rimraf.