Consistent errors across OSs for ensurefile #698
Conversation
lukechilds
changed the title
|
@RyanZim I'm calling Seems a bit hacky, but I don't think there's a way to manually create internal Node.js errors? Alternatively we could just return our own consistent custom error for all OSs. It could have a |
| if (err) return callback(err) | ||
| callback() | ||
| }) | ||
| } |
There was a problem hiding this comment.
Not too happy with this, seems a bit unreadable. It's been a while since I've worked with callbacks. Cleanup suggestions welcome.
|
@RyanZim This PR resolves the related issue. Let me know if you're ok with the method used. // CC @TanninOne |
lukechilds
changed the title
There was a problem hiding this comment.
Sorry so long in reviewing this; I like the overall approach; but it's a bit inefficient. We're calling pathExists on the dirname, then if it exists, we're stating it to check if it's a directory. It'd probably be better to just make one stat call, and if it errors, use that as an indication that the dir doesn't exist and should be created.
@lukechilds are you up to revising this, or shall I take it?
Resolves #696
Ensures that if you do something like
ensureFile('/foo/bar.txt/narf.txt')anENOTDIRerror is always returned.Before this PR
ENOTDIRis returned for macOS and Linux but Windows returnsENOENTwhich is misleading.