Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fs.realpath.native in envs that support it #682

Merged
merged 5 commits into from
May 14, 2019
Merged

Add support for fs.realpath.native in envs that support it #682

merged 5 commits into from
May 14, 2019

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented May 13, 2019 •
edited
Loading

Closes #650

@RyanZim RyanZim requested review from JPeer264 and manidlou May 13, 2019 16:55
@coveralls
Copy link

coveralls commented May 13, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 83.835% when pulling 8893617 on realpath.native into 32a65ff on master.

@manidlou
Copy link
Collaborator

good! so we don't need to do anything for fs.realpathSync.native?

@RyanZim
Copy link
Collaborator Author

RyanZim commented May 13, 2019

I think that should work without anything special, since we don't have promises in the mix, but it wouldn't hurt to add a test.

@RyanZim RyanZim merged commit fa661f3 into master May 14, 2019
@RyanZim RyanZim deleted the realpath.native branch May 14, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manidlou manidlou manidlou approved these changes

@JPeer264 JPeer264 Awaiting requested review from JPeer264

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanZim @coveralls @manidlou