This fixes (what I think) is a bug in copySync #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is that copySync applies the filter **only** at the root level of a recursive copy. This adds a test (that failed with the original code) that checks to make sure that the filter is applied recursively. The patch to lib/copy.js then addresses this issue with a simple fix and the tests pass again with the patch.
mtiller
added a commit
to xogeny/cadeau
that referenced
this pull request
Feb 26, 2014
This adds watching to all files that are copied from the users source material (we don't watch the cadeau files). However, this trick doesn't quite work yet because of a bug in fs-extra which is detailed here: jprichardson/node-fs-extra#52 But assuming that pull request is accepted, then once that fix is available via npm then the watching should work fine. Until then, we wait.
jprichardson
added a commit
that referenced
this pull request
Mar 1, 2014
This fixes (what I think) is a bug in copySync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that copySync applies the filter only at the root level of a recursive
copy. This adds a test (that failed with the original code) that checks to make sure that
the filter is applied recursively. The patch to lib/copy.js then addresses this issue
with a simple fix and the tests pass again with the patch.