Docs enhanced walk sync #336
Closed
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
reviewed
Dec 31, 2016
| @@ -452,15 +452,19 @@ recommend this resource as a good starting point: https://strongloop.com/strongb | |||
|
|
|||
| ### walkSync(dir) | |||
|
|
|||
| Lists all files inside a directory recursively | |||
| Lists all files and directories along with their `fs.stats`, inside a directory recursively. | |||
There was a problem hiding this comment.
Not sure how this should be worded, but this is a bit confusing.
There was a problem hiding this comment.
agreed. What about put it just like Lists all files and directories inside a directory recursively. or Lists all paths inside a directory recursively., since it explains what it returns, right after that.
There was a problem hiding this comment.
Lists all files and directories inside a directory recursively. SGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is regarding #310. I updated the docs to reflect the enhanced
walkSyncmethod. Thanks.