Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs_extra.copySync #33

Merged
merged 2 commits into from
Oct 12, 2013
Merged

fs_extra.copySync #33

merged 2 commits into from
Oct 12, 2013

Conversation

sri-rang
Copy link
Contributor

Implemented copySync and tested it based on copy async's existing tests

@sri-rang
Copy link
Contributor Author

I need to add a parameter to ignore file patterns in copySync.

For example, I want to copy all files from src to dest except .less files.

Is that something you'd like to merge with the main library?

@jprichardson
Copy link
Owner

I think that I'd accept it if it was consistent with the copy method. i.e. it'd need to be implemented in the copy method as well.

jprichardson added a commit that referenced this pull request Oct 12, 2013
@jprichardson jprichardson merged commit 044d296 into jprichardson:master Oct 12, 2013
@jprichardson
Copy link
Owner

I just reviewed ncp (what fs-extra uses) options. You can see it here: https://github.com/AvianFlu/ncp Notice the filter option? I think I like that style. If you implemented it like that, I'd accept that.

@sri-rang
Copy link
Contributor Author

Ah okay, ncp implements a whitelist via filter whereas I originally wanted to implement a blacklist ignore.

But a whitelist also works for me .. I try and implement this in the next few days.

@sri-rang
Copy link
Contributor Author

Implemented here #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants