Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fs-promise as fs-extra-promise alternative #322

Merged
merged 2 commits into from
Nov 21, 2016

Conversation

graingert
Copy link
Contributor

No description provided.

Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM.

@jprichardson ?

Or you can use a dedicated package:

- [`fs-extra-promise`](https://github.com/overlookmotel/fs-extra-promise) uses Bluebird.
- [`fs-promise`](https://github.com/kevinbeaty/fs-promise) uses Any-Promise and also covers [`mz/fs`](https://github.com/normalize/mz/blob/master/fs.js).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you should also link to https://github.com/kevinbeaty/any-promise.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.407% when pulling a29aafe on graingert:patch-1 into ac89f5a on jprichardson:1.x.

@jprichardson jprichardson merged commit 8b15acb into jprichardson:1.x Nov 21, 2016
@graingert graingert deleted the patch-1 branch November 21, 2016 15:44
@RyanZim
Copy link
Collaborator

RyanZim commented Nov 21, 2016

@jprichardson Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants