Adds basic (string, buffer) support for ensureFile content #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really appreciate your initiative here. I do wish that you would have waited though (to save yourself time from wasted PR) so that we could elaborate on our discussion in #164. I'm against this PR, but will leave it open for a bit to think about it. |
|
@jprichardson I appreciate you leaving this open to consider it, I'd love to chat more about it. Personally I don't think that offering this out of the box is a bad idea, we can always come back to extending the arg functionality to be more complex later. |
|
Closing this for now as I really want to get this module to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.