copy: options object or filter to pass to ncp

[overlookmotel]

Hi.

This PR allows copy() to be called with the following signature:

fs.copy(src, dest, [options], callback)

The options object is passed to ncp. The original signature fs.copy(src, dest, [filters], callback) still works as it checks for a function or RexExp and if so treats it as a filter option. All tests pass.

My use case is wanting to pass in a transform function to ncp. Yes, OK, I could just use ncp module direct, but I've got used to using fs-extra and I like it!

I understand if you think this adds extra complexity and don't want it, but please let me know either way, so I can publish a fork instead for my own use if needs be.

[jprichardson]

Thanks! I'll review tomorrow, but I don't see any issues with it ATM.

On Sun, Jan 4, 2015 at 11:06 AM, overlookmotel [email protected]
wrote:

Hi.

This PR allows copy() to be called with the following signature:

fs.copy(src, dest, [options], callback)

The options object is passed to ncp. The original signature fs.copy(src,
dest, [filters], callback) still works as it checks for a function or
RexExp and if so treats it as a filter option. All tests pass.

My use case is wanting to pass in a transform function to ncp. Yes, OK, I
could just use ncp module direct, but I've got used to using fs-extra and I
like it!

I understand if you think this adds extra complexity and don't want it,
but please let me know either way, so I can publish a fork instead for my

own use if needs be.

You can merge this Pull Request by running

git pull https://github.com/overlookmotel/node-fs-extra copy-options

Or view, comment on, or merge it at:

#100
Commit Summary

• copy: options object or filter to pass to ncp

File Changes

• M lib/copy.js
  https://github.com/jprichardson/node-fs-extra/pull/100/files#diff-0
  (14)
• M test/copy.test.js
  https://github.com/jprichardson/node-fs-extra/pull/100/files#diff-1
  (10)

Patch Links:

• https://github.com/jprichardson/node-fs-extra/pull/100.patch
• https://github.com/jprichardson/node-fs-extra/pull/100.diff

—
Reply to this email directly or view it on GitHub
#100.

Simple & Secure Bitcoin Wallet: https://www.coinbolt.com
Bitcoin / JavaScript: http://cryptocoinjs.com
Follow me on Twitter: http://twitter.com/jprichardson

[jprichardson]

https://github.com/jprichardson/node-fs-extra/releases/tag/0.14.0