-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing undefined options to move() #947
Comments
Right, both callback and options are optional; you're passing |
Yes but in JS passing undefined as a parameter should mean the same as not passing it. And if I am making a wrapper around your method then I shouldn't have to check if the optional field is not passed in. For instance with default params, passing undefined means "use default". |
Ah, true; this does make wrappers inconvenient. PR welcome to fix. |
move
fs-extra
version:**10.0.1The follow code:
produces the following type error:
TypeError: Cannot read property 'overwrite' of undefined
The error seems to be from the handling of
optional callback
andoptional options
on line 12-15 oflib/move/move.js
The text was updated successfully, but these errors were encountered: