Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: make note of graceful-fs usage in readme #562

Closed
aikar opened this issue Mar 28, 2018 · 1 comment
Closed

readme: make note of graceful-fs usage in readme #562

aikar opened this issue Mar 28, 2018 · 1 comment
Labels
documentation

Comments

@aikar
Copy link

aikar commented Mar 28, 2018

I was reviewing my code base to find places I should replace fs with graceful-fs, and encountered my use of fs-extra.

I see that fs-extra does use graceful-fs under the hood, so I'm good, but this wasn't apparent until I did some digging to find this detail.

Suggesting that the readme make note in some way that FS calls do use graceful-fs.
@RyanZim
Copy link
Collaborator

RyanZim commented Mar 28, 2018

👍 Good idea, PR welcome.

RyanZim added a commit that referenced this issue Apr 11, 2018
@RyanZim
Add docs that graceful-fs is used
6b0265e 
Fixes #562
@RyanZim RyanZim mentioned this issue Apr 11, 2018
Merged
@RyanZim RyanZim closed this as completed in eb4901b May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aikar @RyanZim