-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es6 refactoring #355
Comments
Yeah, Node 4+ supports most, but not all ES6 features. Given that this is a large codebase, porting to ES6 will take some time. Currently, I've had a fairly passive approach to this; when I worked on a certain part of the codebase, I would port it to ES6. If you want to work on this, thought, PRs welcome. @jprichardson Do you have ES6 stylistic preferences? (i.e. should |
We should avoid var and use let/const if we can. |
@jprichardson @RyanZim regarding the codebase, both internally and for the exported functions, do we want to keep the callback style or we want to change that to promise-based? |
@manidlou: @jprichardson & I have discussed promise support via email in the past. It's something we definitely want to do sometime, but we want to do it right. That means:
We also want a solution that will allow incremental porting of the internals to promises (i.e. our solution must be able to wrap both promise and callback functions). I've been planning on attacking this as soon as I get time; I wanted to do it for v2, but it didn't happen. |
* master: (59 commits) Document `outputFile()` only supports a file path move(): fall back to streams when hard links aren't supported Refactor test.js Refactor test remove (closes jprichardson#355) Refactor test move Refactor test mkdirs lib/copy/__tests__/copy-dev-null.test.js: Edit copy-dev-null test description docs/copy.md: Refactor copy filter example Add done() to copySync tests when setTimeout() is used Remove unnecessary param from filter regex in copy and copySync, remove done() from copySync test Update: arrow functions simplified Refactor docs Refactor test output Refactor test util Refactor test json Refactor test ensure Add dest parameter to filter option in copy and copySync Refactor test empty Refactor missing var's Refactor test copy-sync ...
Since just Node v4+ is supported wouldn't it be could to rewrite everything into ES6?
The text was updated successfully, but these errors were encountered: