-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs.copy fails with chmod error when disk under heavy use #326
Labels
Milestone
Comments
I believe you are correct. Feel like submitting a PR? We'll be releasing 2.0 after Jan 1st and this would make in time for that release. |
OK |
nicks
pushed a commit
to Medium/node-fs-extra
that referenced
this issue
Dec 20, 2016
nicks
pushed a commit
to Medium/node-fs-extra
that referenced
this issue
Dec 20, 2016
nicks
pushed a commit
to Medium/node-fs-extra
that referenced
this issue
Dec 20, 2016
nicks
pushed a commit
to Medium/node-fs-extra
that referenced
this issue
Dec 21, 2016
bluelovers
added a commit
to bluelovers/node-fs-extra
that referenced
this issue
Jan 9, 2017
* master: (687 commits) Add fs-promise as fs-extra-promise alternative Move klaw to devDeps Remove walk() & walkSync() Refactor move() tests Cleanup lib/move/index.js Rename clobber to overwrite BREAKING: Drop Node v0.10 & io.js support BREAKING: Do not error when copy destination exists & clobber: false Use writeStream 'finish' event instead of 'close'. Fixes jprichardson#326 copySync() should apply filter to directories like copy() lib/walk-sync: enhance walkSync to return path and stats Adding copy sync test for src file without write perms Fix remove() no-globbing tests to skip/pass on Windows Test that remove() ignores glob characters. Remove move()'s broken limit option Fix move clobber tests to work around graceful-fs bug. Fix incorrect anchor link README: Node v0.12 deprecation notice. 1.0.0 CHANGELOG: add issues ...
bluelovers
added a commit
to bluelovers/node-fs-extra
that referenced
this issue
Jan 9, 2017
* develop: (43 commits) Add fs-promise as fs-extra-promise alternative Move klaw to devDeps Remove walk() & walkSync() Refactor move() tests Cleanup lib/move/index.js Rename clobber to overwrite BREAKING: Drop Node v0.10 & io.js support BREAKING: Do not error when copy destination exists & clobber: false Use writeStream 'finish' event instead of 'close'. Fixes jprichardson#326 copySync() should apply filter to directories like copy() lib/walk-sync: enhance walkSync to return path and stats Adding copy sync test for src file without write perms Fix remove() no-globbing tests to skip/pass on Windows Test that remove() ignores glob characters. Remove move()'s broken limit option Fix move clobber tests to work around graceful-fs bug. Fix incorrect anchor link README: Node v0.12 deprecation notice. 1.0.0 CHANGELOG: add issues ...
@popod If this issue still exists, please open a new issue with a minimal, complete, and verifiable example. Thanks! |
Repository owner
locked and limited conversation to collaborators
Feb 7, 2017
rajr5
pushed a commit
to rajr5/node-fs-extra
that referenced
this issue
Jun 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Sometimes, when the disk is under heavy use, we see fs.copy fail with the following error:
We tracked down the error to this line: https://github.com/jprichardson/node-fs-extra/blob/1.x/lib/copy/ncp.js#L111
My current hypothesis is that the stream
finish
event is just for generic stream flush, and doesn't guarantee that the underlying filesystem operations have completed. If I change it to 'close', the issue goes away.That said, I've very vague on the intended semantics of nodejs stream events, so I might be on the totally wrong path here.
The text was updated successfully, but these errors were encountered: