.ensureDir(..) fails silently when passed an invalid path...

[flynx]

To reproduce:

fs.ensureDir('l:/tmp/foo:moo', err => console.log('>>>', err) )

Expected:

A error is generated and passed to the callback.

Result:

• The callback is never called
• CPU loaded -- looks like an infinite loop (did not investigate deeper)

NOTE: for now tested only on windows.

[jprichardson]

Funny, I just started looking at this yesterday. Related: #209, #93.

[jprichardson]

Suggestions on a clean fix? My initial plan would be to just test for invalid characters in the path...

[flynx]

@jprichardson I did not dive into the implementation, but in general I think it's obvious, pass an error to the callback in the same manner as native node .mkdir(..) does -- on first dir that fails... and infinite loops and recursion are definitely out of the questions ;)

fs.mkdir('l:/tmp/foo:moo', err => console.log('>>>', err) )

UPDATE:
I'd also keep the directories up to the error, it's more logical and less error-prone than trying to remove directories that some other thread might also be using already.

Another solution would be to syntax-check the path before creating anything, this way one would avoid leaks and managing stray directories, but here we'll have to implement/use OS-specific check, plus there are things that can't be checked easily before actually touching the file system, like access rights/ACLs, so the first approach still seems preferable (IMHO).

[jprichardson]

but in general I think it's obvious, pass an error to the callback in the same manner as native node .mkdir(..) does -- on first dir that fails... and infinite loops and recursion are definitely out of the questions ;)

This is oversimplifying the problem ;) I'll come up with something.

[flynx]

Appears to be working fine now, thanks!!