Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on including a directory tree / file watcher? #13

Closed
jprichardson opened this issue Oct 12, 2012 · 9 comments
Closed

Thoughts on including a directory tree / file watcher? #13

jprichardson opened this issue Oct 12, 2012 · 9 comments

Comments

@jprichardson
Copy link
Owner

Probably this one... https://github.com/mikeal/watch

@davidbourguignon
Copy link

@jprichardson @mikeal Including a directory tree watcher in fs-extra makes sense, indeed! For more details, see my comment on the issue related to the walker.

@jprichardson
Copy link
Owner Author

I want to do this, but there are so many. I'm not sure which is the best.

@mikeal
Copy link

mikeal commented Aug 8, 2013

watch is probably the most used but i'm not sure about best. the problem is harder than it looks and while watch has the benefit of a couple years worth of bug fixes, it was written early in node's history and doesn't follow some of the best patterns we came to later on in the community so I wouldn't be surprised if someone has written a better one by now.

@jprichardson
Copy link
Owner Author

@mikeal Do you see any problems with this one: https://github.com/paulmillr/chokidar?

@mikeal
Copy link

mikeal commented Sep 26, 2013

@jprichardson it's in coffeescript...

@jprichardson
Copy link
Owner Author

Ya, that bothers me too.

@cadorn
Copy link

cadorn commented May 27, 2014

don't include a directory tree watcher. I like that this lib provides a more advanced FS API but uses common FS primitives to do so. file watching is still an evolving science (especially when dealing with many directories/files).

I am strongly against including a file watcher. Such features should go into fs-util or something like that which would sit on top of fs-extra.

@cadorn
Copy link

cadorn commented May 27, 2014

I have an interest in keeping the fs-extra API portable to other implementations and languages.

@jprichardson jprichardson changed the title Thoughts on including a directory tree watcher? Thoughts on including a directory tree / file watcher? May 27, 2014
@jprichardson
Copy link
Owner Author

For the time being, I see no reason to include file watching into fs-extra. chokidar is pretty damn good and fortunately, not written in CoffeeScript anymore. Chokidar is now the recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants