Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on including a file walker? #11

Closed
jprichardson opened this issue Oct 8, 2012 · 7 comments
Closed

Thoughts on including a file walker? #11

jprichardson opened this issue Oct 8, 2012 · 7 comments

Comments

@jprichardson
Copy link
Owner

I really like this one: https://github.com/daaku/nodejs-walker

@jprichardson
Copy link
Owner Author

@superjoe30 what's your opinion on this? Do you think that it's too much too include the fs-extra module?

@andrewrk
Copy link

andrewrk commented Oct 9, 2012

Tough call. I'm leaning towards thinking that it does make sense to include. fs.readdir is a way of reading directories; walk is a higher level way of reading directories.

You may want to double check that this particular module handles circular symlinks correctly, as well as providing a way to cancel an in-progress walk.

@davidbourguignon
Copy link

@jprichardson @superjoe30 I agree with both of you that including a file walker in fs-extra makes sense.

From a functional perspective, I would say that people interested in low-level, single file, single directory, single filesystem functionalities, etc., will go for node-fs and those looking for high-level, multiple files, multiple directories, multiple filesystems functionalities, etc., will go for node-fs-extra.

Therefore, this makes a lot of sense to consider fs-extra as a collection of modules achieving this goal and delivering a solution in one consistently designed package to developers. What do you think?

@jprichardson
Copy link
Owner Author

I think this needs to be done as well... I just don't know if there is a better one than the one that I referenced above. I'm open for suggestions.

@q2dg
Copy link

q2dg commented Oct 28, 2014

What about https://github.com/thlorenz/readdirp?
Its stream api makes it wonderful!

@andrewrk
Copy link

My fork of findit is the most robust module I can find: https://github.com/andrewrk/node-findit

@jprichardson
Copy link
Owner Author

Closing this in favor of discussion in #63

Repository owner deleted a comment from TechQuery Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants