Skip to content

Commit

Permalink
Fix unwanted team review request deletion
Browse files Browse the repository at this point in the history
Add missing issue_id = ? to where clause
Fixes go-gitea#17251
  • Loading branch information
jpraet committed Oct 7, 2021
1 parent 7b1153e commit 0fb2c76
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion models/review.go
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ func SubmitReview(doer *User, issue *Issue, reviewType ReviewType, content, comm
// try to remove team review request if need
if issue.Repo.Owner.IsOrganization() && (reviewType == ReviewTypeApprove || reviewType == ReviewTypeReject) {
teamReviewRequests := make([]*Review, 0, 10)
if err := sess.SQL("SELECT * FROM review WHERE reviewer_team_id > 0 AND type = ?", ReviewTypeRequest).Find(&teamReviewRequests); err != nil {
if err := sess.SQL("SELECT * FROM review WHERE issue_id = ? AND reviewer_team_id > 0 AND type = ?", issue.ID, ReviewTypeRequest).Find(&teamReviewRequests); err != nil {
return nil, nil, err
}

Expand Down

0 comments on commit 0fb2c76

Please sign in to comment.