Add github workflow. #195
Merged
Add github workflow. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshilliard
commented
Dec 10, 2020
| @@ -327,8 +327,11 @@ public synchronized void close() throws HibernateException | |||
| { | |||
| if (session != null) | |||
| { | |||
| session.close(); | |||
| session = null; | |||
| synchronized (DB.class) | |||
There was a problem hiding this comment.
This is to guard against this error I was seeing:
org.jpos.gl.AccountLockTest > executionError FAILED
org.hibernate.HibernateException: Detected concurrent management of connection resources. This might indicate a multi-threaded use of Hibernate in combination with managed resources, which is not supported.
at org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl.releaseConnection(LogicalConnectionManagedImpl.java:221)
at org.hibernate.resource.jdbc.internal.LogicalConnectionManagedImpl.close(LogicalConnectionManagedImpl.java:258)
at org.hibernate.engine.jdbc.internal.JdbcCoordinatorImpl.close(JdbcCoordinatorImpl.java:175)
at org.hibernate.internal.AbstractSharedSessionContract.close(AbstractSharedSessionContract.java:342)
at org.hibernate.internal.SessionImpl.closeWithoutOpenChecks(SessionImpl.java:385)
at org.hibernate.internal.SessionImpl.close(SessionImpl.java:361)
at org.jpos.ee.DB.close(DB.java:330)
at org.jpos.gl.GLSession.close(GLSession.java:1520)
at org.jpos.gl.TestBase.tearDownBase(TestBase.java:100)
jameshilliard
force-pushed
the
actions
branch
from
1e5064a to
07bd4ed
Compare
jameshilliard
force-pushed
the
actions
branch
from
07bd4ed to
c61e544
Compare
ar
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.