Some of the line-heights in the text characteristic have been calculated inconsistently

[joshwooding]

Latest version

• I have tested the latest version

Description

The line-heights with the formula: round(font-size * 1.3).

The top table is current, the bottom in next.
The numbers marked in red are incorrect. lh = line height, e lh = expected line height.

Steps to reproduce

.

Expected behavior

No response

Package name(s)

Theme (@salt-ds/theme)

Package version(s)

No response

Browser

• Chrome
• Safari
• Firefox
• Microsoft Edge

Operating system

• macOS
• Windows
• Linux
• iOS
• Android

Are you a JPMorgan Chase & Co. employee?

• I am an employee of JPMorgan Chase & Co.

[origami-z]

I can not recall any odd number line height occurs in memory, where in the process does this fall apart?

[joshwooding]

I can not recall any odd number line height occurs in memory, where in the process does this fall apart?

We do have odd number line-heights (some of the display text), but I've mentioned it in #4226 that you get a worse outcome. #4223 is caused by this.

[joshwooding]

@pseys @origami-z I think h1 in td next was missed in any previous next text work. I believe in Figma it's already been changed to 55px but code still uses 54px