Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialogs in touch density always have a scrollbar #4223

Open
1 of 11 tasks
joshwooding opened this issue Oct 3, 2024 · 2 comments
Open
1 of 11 tasks

Dialogs in touch density always have a scrollbar #4223

joshwooding opened this issue Oct 3, 2024 · 2 comments
Labels
community For issues that have been raised by folks outside the core Salt team component: dialog type: bug 🪲 Something isn't working

Comments

@joshwooding
Copy link
Contributor

joshwooding commented Oct 3, 2024 •
edited
Loading

Latest version

  • I have tested the latest version

Description

Due to #4224 dialogs in TD will always have a scrollbar

Steps to reproduce

https://storybook.saltdesignsystem.com/?path=/story/core-dialog--default&globals=density:touch

Expected behavior

No response

Package name(s)

Core (@salt-ds/core)

Package version(s)

No response

Browser

  • Chrome
  • Safari
  • Firefox
  • Microsoft Edge

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@joshwooding joshwooding added type: bug 🪲 Something isn't working status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Oct 3, 2024
@joshwooding joshwooding added component: dialog and removed status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Oct 3, 2024
@joshwooding joshwooding mentioned this issue Oct 3, 2024
Open
11 tasks
@origami-z
Copy link
Contributor

This is happening on MacOS Chrome and Firefox, not Mac or iOS Safari

@origami-z
Copy link
Contributor

+1 from SO 90145

@origami-z origami-z added the community For issues that have been raised by folks outside the core Salt team label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community For issues that have been raised by folks outside the core Salt team component: dialog type: bug 🪲 Something isn't working
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

No branches or pull requests
2 participants
@origami-z @joshwooding